On Sun, Aug 09, 2020 at 12:33:43PM -0400, Tom Lane wrote: > I don't see how psql could obtain a "real" list of foreign schemas > from an arbitrary FDW, even if it magically knew which server the > user would specify later in the command. So this behavior seems fine. > It has some usefulness, while not completing at all would have none.
Sounds fine to me as well. The LIMIT TO and EXCEPT clauses are
optional, so using TailMatches() looks fine.
+ else if (TailMatches("FROM", "SERVER", MatchAny, "INTO", MatchAny))
+ COMPLETE_WITH("OPTIONS")
Shouldn't you complete with "OPTIONS (" here?
It would be good to complete with "FROM SERVER" after specifying
EXCEPT or LIMIT TO, you can just use "(*)" to include the list of
tables in the list of elements checked.
--
Michael
signature.asc
Description: PGP signature
