Hi!
> 17 авг. 2020 г., в 21:04, Pavel Borisov <pashkin.e...@gmail.com> написал(а):
>
> Postgres Professional: http://postgrespro.com
> <v6-0001-Covering-SP-GiST-index-support-for-INCLUDE-column.patch>
I'm looking into the patch. I have few notes:
1. I see that in src/backend/access/spgist/README you describe SP-GiST tuple as
sequence of {Value, ItemPtr to heap, Included attributes}. Is it different from
regular IndexTuple where tid is within TupleHeader?
2. Instead of cluttering tuple->nextOffset with bit flags we could just change
Tuple Header for leaf tuples with covering indexes. Interpret tuples for
indexes with included attributes differently, iff it makes code cleaner. There
are so many changes with SGLT_SET_OFFSET\SGLT_GET_OFFSET that it seems viable
to put some effort into research of other ways to represent two bits for null
mask and varatts.
3. Comment "* SPGiST dead tuple: declaration for examining non-live tuples"
does not precede relevant code. because struct SpGistDeadTupleData was not
moved.
Thanks!
Best regards, Andrey Borodin.
