> > >>>> OK, this version contains pre-generated nss files, and passes a full > >>>> buildfarm run including the ssl test module, with both openssl and NSS. > >>>> That should keep the cfbot happy :-) > > Turns out the CFBot doesn't like the binary diffs. They are included in this > version too but we should probably drop them again it seems. >
I did ask Thomas about this, he was going to try to fix it. In principle we should want it to accept binary diffs exactly for this sort of thing. > The attached v9 contains mostly a first stab at getting some documentation > going, it's far from completed but I'd rather share more frequently to not > have > local trees deviate too much in case you've had time to hack as well. I had a > few documentation tweaks in the code too, but no real functionality change for > now. > > The 0001 patch isn't strictly necessary but it seems reasonable to address the > various ways OpenSSL was spelled out in the docs while at updating the SSL > portions. It essentially ensures that markup around OpenSSL and SSL is used > consistently. I didn't address the linelengths being too long in this patch > to > make review easier instead. > I'll take a look. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
