On 2018-Jun-01, Craig Ringer wrote: > On 28 May 2018 at 15:06, Craig Ringer <cr...@2ndquadrant.com> wrote: > > > Per topic, the Pg makefiles install pg_regress (for use by extensions) and > > htey install the isolationtester, but they don't install > > pg_isolation_regress. > > > > We should install it too.
I happened to come across this thread by accident, and I tend to agree that we need to install both isolationtester and pg_isolation_regress to the pgxs dirs, just like we do pg_regress. I can't find that isolationtester is installed anywhere though; maybe that changed after you posted this. Anyway, this version of the patch installs both. I did search for evidence in the Makefile's git log that would remove a recipe for installing isolationtester; couldn't find anything. > I'm wondering if I should add ISOLATION support to PGXS too, like we have > REGRESS . This was covered by Michael's d3c09b9b1307 a few months after you posted. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>From 8c81d47ee10bee52b53c8092d8724ce39fed3dfa Mon Sep 17 00:00:00 2001 From: Craig Ringer <cr...@2ndquadrant.com> Date: Fri, 1 Jun 2018 11:26:09 +0800 Subject: [PATCH v3] Install pg_isolation_regress and isolationtester --- src/test/isolation/Makefile | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/test/isolation/Makefile b/src/test/isolation/Makefile index da5e088bdd..d23e2cec64 100644 --- a/src/test/isolation/Makefile +++ b/src/test/isolation/Makefile @@ -18,12 +18,16 @@ OBJS = \ all: isolationtester$(X) pg_isolation_regress$(X) -# Though we don't install these binaries, build them during installation -# (including temp-install). Otherwise, "make -j check-world" and "make -j -# installcheck-world" would spawn multiple, concurrent builds in this -# directory. Later builds would overwrite files while earlier builds are -# reading them, causing occasional failures. -install: | all +install: all installdirs + $(INSTALL_PROGRAM) pg_isolation_regress$(X) '$(DESTDIR)$(pgxsdir)/$(subdir)/pg_isolation_regress$(X)' + $(INSTALL_PROGRAM) isolationtester$(X) '$(DESTDIR)$(pgxsdir)/$(subdir)/isolationtester$(X)' + +installdirs: + $(MKDIR_P) '$(DESTDIR)$(pgxsdir)/$(subdir)' + +uninstall: + rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/pg_isolation_regress$(X)' + rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/isolationtester$(X)' submake-regress: $(MAKE) -C $(top_builddir)/src/test/regress pg_regress.o -- 2.20.1
