On Fri, Oct 16, 2020 at 12:55 PM Ashutosh Bapat <ashutosh.bapat....@gmail.com> wrote: > > Hi All, > Logical replication protocol uses single byte character to identify > different chunks of logical repliation messages. The code uses > character literals for the same. These literals are used as bare > constants in code as well. That's true for almost all the code that > deals with wire protocol. With that it becomes difficult to identify > the code which deals with a particular message. For example code that > deals with message type 'B'. In various protocol 'B' has different > meaning and it gets difficult and time consuming to differentiate one > usage from other and find all places which deal with one usage. Here's > a patch simplifying that for top level logical replication messages. >
+1. I think this will make the code easier to read and understand. I think it would be good to do this in some other parts as well but starting with logical replication is a good idea as that area is still evolving. -- With Regards, Amit Kapila.
