On Wed, Oct 7, 2020 at 9:01 PM Mark Dilger <mark.dil...@enterprisedb.com> wrote: > This next version, attached, has the acl checking and associated > documentation changes split out into patch 0005, making it easier to review > in isolation from the rest of the patch series. > > Independently of acl considerations, this version also has some verbiage > changes in 0004, in response to Andrey's review upthread.
I was about to commit 0001, after making some cosmetic changes, when I
discovered that it won't link for me. I think there must be something
wrong with the NLS stuff. My version of 0001 is attached. The error I
got is:
ccache clang -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Werror=vla -Wendif-labels
-Wmissing-format-attribute -Wformat-security -fno-strict-aliasing
-fwrapv -Wno-unused-command-line-argument -g -O2 -Wall -Werror
-fno-omit-frame-pointer -bundle -multiply_defined suppress -o
amcheck.so verify_heapam.o verify_nbtree.o -L../../src/port
-L../../src/common -L/opt/local/lib -L/opt/local/lib
-L/opt/local/lib -L/opt/local/lib -L/opt/local/lib
-Wl,-dead_strip_dylibs -Wall -Werror -fno-omit-frame-pointer
-bundle_loader ../../src/backend/postgres
Undefined symbols for architecture x86_64:
"_libintl_gettext", referenced from:
_verify_heapam in verify_heapam.o
_check_tuple in verify_heapam.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [amcheck.so] Error 1
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
v19-0001-Extend-amcheck-to-check-heap-pages.patch
Description: Binary data
