Dear Tomas, Daniel, Michael, I missed your e-mails, and I apologize the very late reply. I want you to thank keeping the thread.
> I'm not an ecpg expert (in fact I've never even used it), so my review > is pretty superficial, but I only found a couple of minor whitespace > issues (adding/removing a line/tab) - see the attached file. Thanks, I fixed it. > Kuroda-san, you mentioned the patch is WIP. What other bits you think > are missing / need improvement? I see you mentioned some documentation > is missing - I suppose that's one of the missing pieces? All functionalities I expect has been already implemented in the previous patch, and I thought that only doc and reviews were needed. Finally I attach new patch. This patch contains source changes, a test code, and documentation changes. This one is not WIP. I will try to review other topics on the next Commitfest. Best regards, Hayato Kuroda FUJITSU LIMITED -----Original Message----- From: Michael Meskes <mes...@postgresql.org> Sent: Tuesday, September 15, 2020 7:32 PM To: pgsql-hackers@lists.postgresql.org Subject: Re: ECPG: proposal for new DECLARE STATEMENT > This patch has now been silent for quite a while, unless someone is > interested > enough to bring it forward it seems about time to close it. I am interested but still short on time. I will definitely look into it as soon as I find some spare minutes. Michael -- Michael Meskes Michael at Fam-Meskes dot De Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org
DeclareStmt02.patch
Description: DeclareStmt02.patch
