Michael Paquier <mich...@paquier.xyz> writes:
> On Fri, Oct 23, 2020 at 04:18:13PM -0700, Mark Dilger wrote:
>> On Oct 23, 2020, at 9:07 AM, Tom Lane <t...@sss.pgh.pa.us> wrote:
>>> genhtml: WARNING: function data mismatch at
>>> /home/postgres/pgsql/src/common/unicode_norm.c:102
> I can see the problem on Debian GID with lcov 1.14-2. This points to
> the second declaration of get_code_entry(). I think that genhtml,
> because it considers the code of unicode_norm.c as a whole without its
> CFLAGS, gets confused because it finds the same function to index as
> defined twice. It expects only one definition, hence the warning. So
> I think that this can lead to some incorrect data in the HTML report,
> and the attached patch takes care of fixing that. Tom, does it take
> care of the issue on your side?
Good catch! Yeah, that fixes it for me.
I'd advise not putting conv_compare() between get_code_entry() and
the header comment for get_code_entry(). Looks good otherwise.
regards, tom lane
