On Tue, Oct 27, 2020 at 8:02 PM Alexander Korotkov <aekorot...@gmail.com> wrote: > On Mon, Oct 26, 2020 at 6:45 PM Andrey Borodin <x4...@yandex-team.ru> wrote: > > Thanks for your review, Alexander! > > +1 for avoiding double locking in SimpleLruReadPage_ReadOnly(). > > Other changes seem correct to me too. > > > > > > I've tried to find optimal value for cache size and it seems to me that it > > affects multixact scalability much less than sizes of offsets\members > > buffers. I concur that patch 2 of the patchset does not seem documented > > enough. > > Thank you. I've made a few more minor adjustments to the patchset. > I'm going to push 0001 and 0003 if there are no objections.
I get that patchset v5 doesn't pass the tests due to typo in assert. The fixes version is attached. ------ Regards, Alexander Korotkov
v6-0001-Use-shared-lock-in-GetMultiXactIdMembers-for-offs.patch
Description: Binary data
v6-0002-Make-MultiXact-local-cache-size-configurable.patch
Description: Binary data
v6-0003-Add-conditional-variable-to-wait-for-next-MultXact.patch
Description: Binary data
