On Fri, Nov 13, 2020 at 12:58:52PM +0530, Bharath Rupireddy wrote: > It's not required to set bistate to null as we have allocated myState > with palloc0 in CreateIntoRelDestReceiver, it will anyways be null. > if (!into->skipData) > myState->bistate = GetBulkInsertState(); > > Attaching v4 patch. Please review it.
I have reviewed this one this morning, and applied it after some tweaks. I have reworded some of the comments, fixed some typos, and largely refactored the test cases to stress all the combinations possible. Please note that your patch would have caused failures in the buildfarm, as any role created needs to be prefixed with "regress_". -- Michael
signature.asc
Description: PGP signature
