>
> One thing that doesn't matter is that the modify here seems unnecessary,
> right?
>
> > mdunlinkfork(RelFileNodeBackend rnode, ForkNumber forkNum, bool isRedo)
> > {
> > char *path;
> > - int ret;
> > + int ret = 0;
> > path = relpath(rnode, forkNum
I suppose it is indeed necessary as otherwise the result of the comparison
is not defined in case of 'else' block in the mdunlinkfork() :
346 else
347 {
348 /* Prevent other backends' fds from holding on to the disk
space */
349 do_truncate(path);
.....
356 * Delete any additional segments.
357 */
358 if (ret >= 0)
----------^^^^^^^
--
Best regards,
Pavel Borisov
Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>
