On 03/12/2020 16:10, Heikki Linnakangas wrote:
On 02/12/2020 15:26, Ian Barwick wrote:
On 02/12/2020 20:13, Heikki Linnakangas wrote:
Attached are two patches. The first patch is your original patch, unmodified
(except for a cosmetic rename of the test file). The second patch builds on
that, demonstrating and fixing the issue I mentioned. It took me a while to
create a repro for it, it's easily masked by incidental full-page writes or
because rows created by XIDs that are not marked as committed on the other
timeline are invisible, but succeeded at last.
Aha, many thanks. I wasn't entirely sure what I was looking for there and
recently haven't had the time or energy to dig any further.
Ok, pushed and backpatched this now.
The buildfarm is reporting sporadic failures in the new regression test.
I suspect it's because of timing issues, where a server is promoted or
shut down before some data has been replicated. I'll fix that tomorrow
morning.
- Heikki
