On 2020-12-13 17:49, Tom Lane wrote:
2. Don't allow a default: invent a new HASH_STRING flag, and require that hash_create() calls specify exactly one of HASH_BLOBS, HASH_STRING, or HASH_FUNCTION. This doesn't completely fix the hazard of mindless-copy-and-paste, but I think it might make it a little more obvious. Still requires touching a lot of calls.
I think this sounds best, and also expand the documentation of these flags a bit.
-- Peter Eisentraut 2ndQuadrant, an EDB company https://www.2ndquadrant.com/