Hi, On 2020-12-15 01:22:44 -0800, Jeff Davis wrote: > Attached a simple patch that enforces an all-ASCII restore point name > rather than documenting the possibility of non-ASCII text.
+1 > diff --git a/src/backend/access/transam/xlogfuncs.c > b/src/backend/access/transam/xlogfuncs.c > index 290658b22c..48daed56f6 100644 > --- a/src/backend/access/transam/xlogfuncs.c > +++ b/src/backend/access/transam/xlogfuncs.c > @@ -44,6 +44,8 @@ > static StringInfo label_file; > static StringInfo tblspc_map_file; > > +static bool is_all_ascii(const char *str); Minor nit: I'd put this into common/string.[ch], besides pg_clean_ascii(). Probably renaming it to pg_is_ascii(). Greetings, Andres Freund
