As a minor nitpick, I would leave out the
else printf(_("\nSuccess.\n")); in the --no-instructions case. (I don't know where the pg_upgrade part of this discussion is right now.) -- Peter Eisentraut 2ndQuadrant, an EDB company https://www.2ndquadrant.com/