On Fri, Jan 8, 2021 at 6:33 AM Mark Dilger <mark.dil...@enterprisedb.com> wrote:
> The attached patches, v31, are mostly the same, but with "getopt_long.h"
> included from pg_amcheck.c per Thomas's review, and a .gitignore file added
> in contrib/pg_amcheck/
I couple more little things from Windows CI:
C:\projects\postgresql\src\include\fe_utils/option_utils.h(19):
fatal error C1083: Cannot open include file: 'libpq-fe.h': No such
file or directory [C:\projects\postgresql\pg_amcheck.vcxproj]
Does contrib/amcheck/Makefile need to say "SHLIB_PREREQS =
submake-libpq" like other contrib modules that use libpq?
pg_backup_utils.obj : error LNK2001: unresolved external symbol
exit_nicely [C:\projects\postgresql\pg_dump.vcxproj]
I think this is probably because additions to src/fe_utils/Makefile's
OBJS list need to be manually replicated in
src/tools/msvc/Mkvcbuild.pm's @pgfeutilsfiles list. (If I'm right
about that, perhaps it needs a comment to remind us Unix hackers of
that, or perhaps it should be automated...)
