On 12.01.2021 18:38, Justin Pryzby wrote:
On Tue, Jan 12, 2021 at 08:44:43AM +0300, Konstantin Knizhnik wrote:
On 11.01.2021 20:38, Tomas Vondra wrote:
1) Fixes the MSVC makefile. The list of files is sorted alphabetically,
so I've added the file at the end.
Thank you
This is still failing the windows build.
I think you need something like this, which I have in my zstd/pg_dump patch.
--- a/src/tools/msvc/Solution.pm
+++ b/src/tools/msvc/Solution.pm
@@ -307,6 +307,7 @@ sub GenerateFiles
HAVE_LIBXML2 => undef,
HAVE_LIBXSLT => undef,
HAVE_LIBZ => $self->{options}->{zlib} ? 1 :
undef,
+ HAVE_LIBZSTD => $self->{options}->{zstd} ? 1 :
undef,
Thank you.
I think we should come up with an minimal, prelimininary 0001 patch which is
common between the 3 compression patches (or at least the two using zstd). The
./configure changes and a compressionlibs struct would also be included. I'm
planning to do something like this with the next revision of my patchset.
It will be great to have such common preliminary patch including zstd
support.
--
Konstantin Knizhnik
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
