On Sun, Jan 24, 2021 at 12:24 PM Peter Smith <smithpb2...@gmail.com> wrote: > > On Sat, Jan 23, 2021 at 11:26 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > Few comments: > > ============= > > 1. > > - * So the state progression is always: INIT -> DATASYNC -> SYNCWAIT -> > > - * CATCHUP -> SYNCDONE -> READY. > > + * So the state progression is always: INIT -> DATASYNC -> > > + * (sync worker FINISHEDCOPY) -> SYNCWAIT -> CATCHUP -> SYNCDONE -> > > READY. > > > > I don't think we need to be specific here that sync worker sets > > FINISHEDCOPY state. > > > > This was meant to indicate that *only* the sync worker knows about the > FINISHEDCOPY state, whereas all the other states are either known > (assigned and/or used) by *both* kinds of workers. But, I can remove > it if you feel that distinction is not useful. >
Okay, but I feel you can mention that in the description you have added for FINISHEDCOPY state. It looks a bit odd here and the message you want to convey is also not that clear. -- With Regards, Amit Kapila.
