At Thu, 04 Feb 2021 10:16:47 +0900, torikoshia <torikos...@oss.nttdata.com> wrote in > Chengxi Sun, Yamada-san, Horiguchi-san, > > Thanks for all your comments. > Adding only the number of generic plan execution seems acceptable. > > On Mon, Jan 25, 2021 at 2:10 PM Kyotaro Horiguchi > <horikyota....@gmail.com> wrote: > > Note that ActivePortal is the closest nested portal. So it gives the > > wrong result for nested portals. > > I may be wrong, but I thought it was ok since the closest nested > portal is the portal to be executed.
After executing the inner-most portal, is_plan_type_generic has a value for the inner-most portal and it won't be changed ever after. At the ExecutorEnd of all the upper-portals see the value for the inner-most portal left behind is_plan_type_generic nevertheless the portals at every nest level are indenpendent. > ActivePortal is used in ExecutorStart hook in the patch. > And as far as I read PortalStart(), ActivePortal is changed to the > portal to be executed before ExecutorStart(). > > If possible, could you tell me the specific case which causes wrong > results? Running a plpgsql function that does PREPRE in a query that does PREPARE? regards. -- Kyotaro Horiguchi NTT Open Source Software Center
