On Thu, Feb 4, 2021 at 4:43 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Thu, Feb 4, 2021 at 9:57 AM Peter Smith <smithpb2...@gmail.com> wrote: > > > > On Wed, Feb 3, 2021 at 11:17 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > > > How about if we call replorigin_by_name() inside replorigin_drop after > > > acquiring the lock? Wouldn't that close this race condition? We are > > > doing something similar for pg_replication_origin_advance(). > > > > > > > Yes, that seems ok. > > > > I wonder if it is better to isolate that locked portion > > (replyorigin_by_name + replorigin_drop) so that in addition to being > > called from pg_replication_origin_drop, we can call it internally from > > PG code to safely drop the origins. > > > > Yeah, I think that would be really good.
PSA a patch which I think implements what we are talking about. ---- Kind Regards, Peter Smith. Fujitsu Australia
v1-0001-replorigin_drop_by_name.patch
Description: Binary data
