On Mon, Feb 15, 2021 at 8:13 AM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > On Sat, Feb 13, 2021 at 11:41 AM japin <japi...@hotmail.com> wrote: > > > IIUC, with the current patch, the new ALTER SUBSCRIPTION ... ADD/DROP > > > errors out on the first publication that already exists/that doesn't > > > exist right? What if there are multiple publications given in the > > > ADD/DROP list, and few of them exist/don't exist. Isn't it good if we > > > loop over the subscription's publication list and show all the already > > > existing/not existing publications in the error message, instead of > > > just erroring out for the first existing/not existing publication? > > > > > > > Yes, you are right. Agree with you, I modified it. Please consider v5 > > for further review. > > Thanks for the updated patches. I have a comment about reporting the > existing/not existing publications code. How about something like the > attached delta patch on v5-0002?
Attaching the v6 patch set so that cfbot can proceed to test the patches. The above delta patch was merged into 0002. Please have a look. With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com
v6-0001-Export-textarray_to_stringlist.patch
Description: Binary data
v6-0002-Introduce-a-new-syntax-to-add-drop-publications.patch
Description: Binary data
v6-0003-Test-ALTER-SUBSCRIPTION-.-ADD-DROP-PUBLICATION.patch
Description: Binary data
v6-0004-Add-documentation-for-ALTER-SUBSCRIPTION.ADD-DROP.patch
Description: Binary data
v6-0005-Add-tab-complete-for-ALTER-SUBSCRIPTION.ADD-DROP.patch
Description: Binary data
