At Thu, 18 Feb 2021 18:51:37 +0530, Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> wrote in > On Thu, Feb 18, 2021 at 6:19 PM Peter Eisentraut < > peter.eisentr...@2ndquadrant.com> wrote: > > > Here is an updated patch that just introduces LSN_FORMAT_ARGS(). I > > think the result is quite pleasant. > > > > Thanks a lot Peter for producing this patch. I am fine with it. The way > this is defined someone could write xyz = LSN_FORMAT_ARGS(lsn). But then > they are misusing it so I won't care. Even my proposal had that problem.
As for the side effect by expressions as the parameter, unary operators are seldom (or never) applied to LSN. I think there's no need to fear about other (modifying) expressions, too. As a double-checking, I checked that the patch covers all output by '%X/%X' and " ?>> ?32)" that are handling LSNs, and there's no mis-replacing of the source variables. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
