On Mon, Mar 1, 2021 at 3:14 PM Corey Huinker <corey.huin...@gmail.com> wrote: >> > It seems to me 1 (RI_PLAN_CHECK_LOOKUPPK) is still alive. (Yeah, I >> > know that doesn't mean the usefulness of the macro but the mechanism >> > the macro suggests, but it is confusing.) On the other hand, >> > RI_PLAN_CHECK_LOOKUPPK_FROM_PK and RI_PLAN_LAST_ON_PK seem to be no >> > longer used. (Couldn't we remove them?) >> >> Yeah, better to just remove those _PK macros and say this module no >> longer runs any queries on the PK table. >> >> How about the attached? >> > > Sorry for the delay. > I see that the changes were made as described. > Passes make check and make check-world yet again. > I'm marking this Ready For Committer unless someone objects.
Thank you Corey for the review. -- Amit Langote EDB: http://www.enterprisedb.com