Dear Miyake-san,
I agree your suggestions and I think this patch is basically good.
I put some comments:
* When the following line is input, the error message is not happy.
I think output should be " \sleep command argument must be an integer...".
\sleep foo
-> pgbench: fatal: test.sql:5: unrecognized time unit, must be us, ms or s
(foo) in command "sleep"
\sleep foo
^ error found here
I'm not sure but I think this is caused because `my_command->argv[2]` becomes
"foo".
* A blank is missed in some lines, for example:
> + if (my_command->argc ==2)
A blank should be added between a variable and an operator.
Could you fix them?
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
