On Sun, Mar 7, 2021 at 10:13 PM Zhihong Yu <z...@yugabyte.com> wrote: > Hi, > > + * EXPLAIN ANALYZE CREATE TABLE AS or REFRESH MATERIALIZED VIEW > + * WITH NO DATA is weird. > > Maybe it is clearer to spell out WITH NO DATA for both statements, instead of > sharing it.
Done that way. > - if (!stmt->skipData) > + if (!stmt->skipData && !explainInfo) > ... > + else if (explainInfo) > > It would be cleaner to put the 'if (explainInfo)' as the first check. That > way, the check for skipData can be simplified. Changed. Thanks for review comments. Attaching v7 patch set with changes only in 0002 patch. Please have a look. With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com
v7-0001-Rearrange-Refresh-Mat-View-Code.patch
Description: Binary data
v7-0002-EXPLAIN-EXPLAIN-ANALYZE-REFRESH-MATERIALIZED-VIEW.patch
Description: Binary data
