To Ibrar, Thank you for updating the patch! To Amit, Thank you for checking the patch, and I have confirmed the failure. Now I'm trying to fix it.
2021年3月9日(火) 11:54 Amit Langote <amitlangot...@gmail.com>: > On Tue, Mar 9, 2021 at 2:24 AM Ibrar Ahmed <ibrar.ah...@gmail.com> wrote: > > The patch (pgsql14-truncate-on-foreign-table.v2.patch) does not apply > successfully. > > > > http://cfbot.cputube.org/patch_32_2972.log > > > > patching file contrib/postgres_fdw/expected/postgres_fdw.out > > Hunk #2 FAILED at 9179. > > 1 out of 2 hunks FAILED -- saving rejects to file > contrib/postgres_fdw/expected/postgres_fdw.out.rej > > > > As this is a minor change therefore I have updated the patch. Please > take a look. > > Thanks for updating the patch. I was able to apply it successfully > though I notice it doesn't pass make check-world. > > Specifically, it fails the src/test/subscription/013_partition.pl > test. The problem seems to be that worker.c: apply_handle_truncate() > hasn't been updated to add entries to relids_extra for partitions > expanded from a partitioned table, like ExecuteTruncate() does. That > leads to relids and relids_extra having different lengths, which trips > the Assert in ExecuteTruncateGuts(). > > -- > Amit Langote > EDB: http://www.enterprisedb.com >
