On Tue, Mar 16, 2021 at 9:48 PM Magnus Hagander <mag...@hagander.net> wrote: > Does it really make sense that pg_wait_for_backend_termination() > defaults to waiting *100 milliseconds*, and then logs a warning? That > seems extremely short if I'm explicitly asking it to wait.
I increased the default wait timeout to 5seconds.
> Wait events should be in alphabetical order in pgstat_get_wait_ipc()
> as well, not just in the header (which was adjusted per Fujii's
> comment)
Done.
>
> + (errmsg("could not wait for the termination of
> the backend with PID %d within %lld milliseconds",
>
> That's not true though? The wait succeeded, it just timed out? Isn't
> itm ore like "backend with PID %d did not terminate within %lld
> milliseconds"?
Looks better. Done.
Attaching v10 patch for further review.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
v10-0001-pg_terminate_backend-with-wait-and-timeout.patch
Description: Binary data
