On 1/19/21 4:03 PM, Justin Pryzby wrote:
On Wed, Dec 30, 2020 at 12:33:56PM +0000, Simon Riggs wrote:
There are no tests for the new functionality, please could you add some?
Did you look at the most recent patch?
+CREATE ACCESS METHOD heapdup TYPE TABLE HANDLER heap_tableam_handler;
+CREATE TABLE likeam() USING heapdup;
+CREATE TABLE likeamlike(LIKE likeam INCLUDING ALL);
Also, I just realized that Dilip's toast compression patch adds "INCLUDING
COMPRESSION", which is stored in pg_am. That's an implementation detail of
that patch, but it's not intuitive that "including access method" wouldn't
include the compression stored there. So I think this should use "INCLUDING
TABLE ACCESS METHOD" not just ACCESS METHOD.
Simon, do you know when you'll have a chance to review the updated patch
in [1]?
Regards,
--
-David
da...@pgmasters.net
[1]
https://www.postgresql.org/message-id/20210119210331.GN8560%40telsasoft.com
