On Sat, Mar 20, 2021 at 12:54 PM Peter Smith <smithpb2...@gmail.com> wrote: > > PSA my patch to correct this by firstly doing a HASH_FIND, then only > HASH_REMOVE after we've finished using the ent. >
Why can't we keep using HASH_REMOVE as it is but get the output (entry found or not) in the last parameter of hash_search API and then perform Assert based on that? See similar usage in reorderbuffer.c and rewriteheap.c. -- With Regards, Amit Kapila.