On Mon, Mar 22, 2021 at 10:41:33AM -0400, Robert Haas wrote: > On Sun, Mar 21, 2021 at 7:55 PM Justin Pryzby <pry...@telsasoft.com> wrote: > > Rebased again. > > Thanks, Justin. I committed 0003 and 0004 together as > 226e2be3876d0bda3dc33d16dfa0bed246b7b74f. I also committed 0001 and > 0002 together as 24f0e395ac5892cd12e8914646fe921fac5ba23d, but with > some revisions, because your text was not clear that this is setting > the default for new tables, not new values; it also implied that this > only affects out-of-line compression, which is not true. In lieu of > trying to explain how TOAST works here, I added a link. It looks, > though, like that documentation also needs to be patched for this > change. I'll look into that, and your remaining patches, next.
Thanks. I just realized that if you also push the GUC change, then the docs should change from <string> to <enum> doc/src/sgml/config.sgml: <term><varname>default_toast_compression</varname> (<type>string</type>) -- Justin
