From: Andrey Lepikhov <a.lepik...@postgrespro.ru>
> Macros _() at the postgresExecForeignCopy routine:
> if (PQputCopyEnd(conn, OK ? NULL : _("canceled by server")) <= 0)
> 
> uses gettext. Under linux it is compiled ok, because (as i understood)
> uses standard implementation of gettext:
> objdump -t contrib/postgres_fdw/postgres_fdw.so | grep 'gettext'
> gettext@@GLIBC_2.2.5
> 
> but in MacOS (and maybe somewhere else) we need to explicitly link
> libintl library in the Makefile:
> SHLIB_LINK += $(filter -lintl, $(LIBS)
> 
> Also, we may not use gettext at all in this part of the code.

I'm afraid so, because no extension in contrib/ has po/ directory.  I just 
removed _() and rebased the patch on HEAD.


        Regards
Takayuki        Tsunakawa
                                                

Attachment: v21-0001-Fast-COPY-FROM-into-the-foreign-or-sharded-table.patch
Description: v21-0001-Fast-COPY-FROM-into-the-foreign-or-sharded-table.patch

Reply via email to