> One minor thing - I think "mixtured" is not the > correct word in "+-- partition table mixtured by table and foreign > table". How about something like "+-- partitioned table with both > local and foreign table as partitions"?
Sure. I've fixed this. > The v15 patch basically looks good to me. I have no more comments. Thank you for checking this many times. > CF entry https://commitfest.postgresql.org/32/2972/ still says it's > "waiting on author", do you want to change it to "needs review" if you > have no open points left so that others can take a look at it? Yes, please. 2021年4月7日(水) 10:15 Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com>: > > On Tue, Apr 6, 2021 at 10:15 PM Kazutaka Onishi <oni...@heterodb.com> wrote: > > I've checked v15 patch with "make check-world" and confirmed this passed. > > Thanks for the patch. One minor thing - I think "mixtured" is not the > correct word in "+-- partition table mixtured by table and foreign > table". How about something like "+-- partitioned table with both > local and foreign table as partitions"? > > The v15 patch basically looks good to me. I have no more comments. > > CF entry https://commitfest.postgresql.org/32/2972/ still says it's > "waiting on author", do you want to change it to "needs review" if you > have no open points left so that others can take a look at it? > > With Regards, > Bharath Rupireddy. > EnterpriseDB: http://www.enterprisedb.com
pgsql14-truncate-on-foreign-table.v16.patch
Description: Binary data
