On Wed, Apr 7, 2021 at 1:57 PM Michael Paquier <mich...@paquier.xyz> wrote: > > On Wed, Apr 07, 2021 at 01:24:01PM +0200, Magnus Hagander wrote: > > On Wed, Apr 7, 2021 at 1:01 PM Erik Rijkers <e...@xs4all.nl> wrote: > > > Recently (last day or so), I get this warning from gcc 10.2: > > Same compiler version here, but I did not get warned. Are you using > any particular flag? > > > But that also highlights -- shouldn't that function then also be made > > to use hba_authname(), and the assert moved into the function? That > > seems like the cleanest way? > > Good idea, that's much cleaner this way. Do you like the attached?
That's very close to mine (see one email later). Let's bikeshed about the details. I think it's basically the same for current usecases, but that taking the UserAuth as the parameter is cleaner and potentially more useful for the future. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/
