On 4/8/21 2:40 AM, Julien Rouhaud wrote: > On Wed, Apr 07, 2021 at 11:33:20PM -0700, Andres Freund wrote: >> Hi, >> >> On 2021-04-08 02:05:25 -0400, Tom Lane wrote: >>> So far the buildfarm seems to be turning green after b3ee4c503 ... >>> so I wonder what extra condition is needed to cause the failure >>> Andres is seeing. >> Nothing special, really. Surprised the BF doesn't see it: >> >> andres@awork3:~/build/postgres/dev-assert/vpath$ cat /tmp/test.conf >> force_parallel_mode=regress >> andres@awork3:~/build/postgres/dev-assert/vpath$ make -j48 -s && >> EXTRA_REGRESS_OPTS='--temp-config /tmp/test.conf' make -s -C >> contrib/pg_stat_statements/ check >> All of PostgreSQL successfully made. Ready to install. >> ... >> The differences that caused some tests to fail can be viewed in the >> file >> "/home/andres/build/postgres/dev-assert/vpath/contrib/pg_stat_statements/regression.diffs". >> A copy of the test summary that you see >> above is saved in the file >> "/home/andres/build/postgres/dev-assert/vpath/contrib/pg_stat_statements/regression.out". >> ... > Is think this is because the buildfarm client is running installcheck for the > contribs rather than check, and pg_stat_statements/Makefile has: > > # Disabled because these tests require > "shared_preload_libraries=pg_stat_statements", > # which typical installcheck users do not have (e.g. buildfarm clients). > NO_INSTALLCHECK = 1 > > >
Yeah, Julien is right, we run "make check" for these in src/test/modules but I missed contrib. I have fixed this on crake so we get some immediate coverage and a fix will be pushed to github shortly. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
