Andrew Dunstan <and...@dunslane.net> writes: > On 4/19/21 7:22 PM, Tom Lane wrote: >> I wonder whether we could get away with just replacing the $use_tcp >> test with $TestLib::windows_os. It's not really apparent to me >> why we should care about 127.0.0.not-1 on Unix-oid systems.
> Yeah > The comment is a bit strange anyway - Cygwin is actually going to use > Unix sockets, not TCP. > I think I would just change the test to this: $use_tcp && > $TestLib::windows_os. Works for me, but we need to revise the comment to match. regards, tom lane