Daniel Gustafsson <dan...@yesql.se> writes:
> On 28 Apr 2021, at 22:47, Tom Lane <t...@sss.pgh.pa.us> wrote:
>> This wording is copied-and-pasted from the other similar tests. I agree
>> that it's advocating a solution that might be overkill, but if we change
>> it we should also change the existing messages.
> Good point.
>> I don't mind doing that in HEAD; less sure about the back branches, as
> I think it would be helpful for users to try and give slightly more expanded
> advice while (obviously) still always being safe. I’m happy to take a crack
> at
> that once back unless someone beats me to it.
Seems like s/remove the problem tables/drop the problem columns/
is easy and sufficient.
>> (I think) these are translatable strings.
> If they aren't I think we should try and make them so to as far as we can
> reduce language barrier problems in such important messages.
Checking, I see they do appear in pg_upgrade's po files. So I propose
that we change the existing messages in HEAD but not the back branches.
regards, tom lane
