> On Apr 30, 2021, at 12:29 PM, Robert Haas <robertmh...@gmail.com> wrote:
> 
> OK, how about this version?

I think that's committable.

The only nitpick might be

-                               psprintf("toast value %u was expected to end at 
chunk %d, but ended at chunk %d",
+                               psprintf("toast value %u index scan ended early 
while expecting chunk %d of %d",

When reporting to users about positions within a zero-based indexing scheme, 
what does "while expecting chunk 3 of 4" mean?  Is it talking about the last 
chunk from the set [0..3] which has cardinality 4, or does it mean the 
next-to-last chunk from [0..4] which ends with chunk 4, or what?  The prior 
language isn't any more clear than what you have here, so I have no objection 
to committing this, but the prior language was probably as goofy as it was 
because it was trying to deal with this issue.

Thoughts?

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





Reply via email to