On Sun, May 2, 2021 at 8:44 PM vignesh C <vignes...@gmail.com> wrote: > > On Sat, May 1, 2021 at 9:02 PM Bharath Rupireddy > <bharath.rupireddyforpostg...@gmail.com> wrote: > > > > On Sat, May 1, 2021 at 7:25 PM vignesh C <vignes...@gmail.com> wrote: > > > > > I'm not attaching above one line change as a patch, maybe Vignesh can > > > > > merge this into the main patch. > > > > > > Thanks for the comments. I have merged the change into the attached patch. > > > Thoughts? > > > > Thanks! v4 basically LGTM. Can we park this in the current commitfest > > if not done already? > > > > Upon looking at the number of places where we have the "option \"%s\" > > specified more than once" error, I, now strongly feel that we should > > use goto duplicate_error approach like in compute_common_attribute, so > > that we will have only one ereport(ERROR. We can change it in > > following files: copy.c, dbcommands.c, extension.c, > > compute_function_attributes, sequence.c, subscriptioncmds.c, > > typecmds.c, user.c, walsender.c, pgoutput.c. This will reduce the LOC > > greatly. > > > > Thoughts? > > I have made the changes for this, I have posted the same in the v5 > patch posted in my earlier mail.
Thanks! The v5 patch looks good to me. Let's see if all agree on the goto duplicate_error approach which could reduce the LOC by ~80. I don't see it in the current commitfest, can we park it there so that the patch will get tested on cfbot systems? With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com
