On Thu, May 06, 2021 at 01:22:27PM -0400, Tom Lane wrote: > I'm curious though why it took this long for anyone to complain. > I'd supposed that people were running sqlsmith against HEAD on > a pretty regular basis.
I think it's also becase sqlsmith would need to run against the v14 *client* library. I don't know about anyone else's workflow, but I tend not to "make install", but work with binaries out of ./tmp_install. There's a few changes needed on sqlsmith HEAD, but I guess nobody would have gotten that far if the connection was failing (or rather, detected as such). diff --git a/grammar.cc b/grammar.cc index 62aa8e9..76491ff 100644 --- a/grammar.cc +++ b/grammar.cc @@ -327,7 +327,11 @@ query_spec::query_spec(prod *p, struct scope *s, bool lateral) : search = bool_expr::factory(this); - if (d6() > 2) { + if (d6() > 4) { + ostringstream cons; + cons << "order by 1 fetch first " << d100() + d100() << " rows with ties"; + limit_clause = cons.str(); + } else if (d6() > 2) { ostringstream cons; cons << "limit " << d100() + d100(); limit_clause = cons.str(); diff --git a/postgres.cc b/postgres.cc index f2a3627..1c0c55f 100644 --- a/postgres.cc +++ b/postgres.cc @@ -30,6 +30,7 @@ bool pg_type::consistent(sqltype *rvalue) case 'c': /* composite type */ case 'd': /* domain */ case 'r': /* range */ + case 'm': /* multirange */ case 'e': /* enum */ return this == t;