On 2021-May-06, Peter Smith wrote: > PSA v3 of the patch. Same as before, but now also renames the global > variable from "wrconn" to "lrep_worker_wrconn".
I think there are two patches here -- the changes to AlterSubscription_refresh are a backpatchable bugfix, and the rest of it can just be applied to master. In my mind we make a bit of a distinction for global variables by using CamelCase rather than undercore_separated_words. There are plenty that violate that "rule" of course, but ISTM that makes them stand more and it's less likely we've made this mistake. So I would name the variable LogRepWALRcvConn or something like that. My €0.02. -- Álvaro Herrera Valdivia, Chile "Entristecido, Wutra (canción de Las Barreras) echa a Freyr a rodar y a nosotros al mar"
