On Sat, May 08, 2021 at 03:44:57PM -0400, Tom Lane wrote: > I tried that, by adding a > shim function to regress.c, and got a most gratifying result: > on my machine opr_sanity's runtime with > debug_invalidate_system_caches_always = 1 drops from > 29m9s to 3m19s. Without CCA the speedup is far less impressive, > 360ms to 305ms, but that's still useful. Especially since this > makes the test strictly more accurate.
The speedup is quite welcome and still impressive in both cases. > Anyway, I propose that we ought to sneak this into HEAD, since > it's only touching test code and not anything production-critical. +1 for pushing it in HEAD. Looking at the patch, explicitly_binary_coercible wasn't used since e9f42d529f990f94e1b7bdcec4a1111465c85326 (and was renamed there too). Just to be sure, is it ok to remove it, as it was described as > --- We don't currently use this for any tests in this file, but it is a > --- reasonable alternative definition for some scenarios. It would still be in the git history in needed, so I'm not objecting.
