On Mon, May 10, 2021 at 10:09:40AM -0400, Tom Lane wrote: > Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> writes: >> if (value < 0) "requires a zero or positive integer value" >> if (value <= 0) "requires a positive integer value" > > I was thinking of avoiding the passive voice and writing > > "foo must be greater than zero"
Sounds like a good idea to me. >> I'm not sure whether we should consider changing these messages: >> remainder for hash partition must be a non-negative integer >> parallel vacuum degree must be a non-negative integer >> repeat count size must be a non-negative integer >> number of workers must be a non-negative integer >> %s requires a non-negative numeric value >> distance in phrase operator should be non-negative and less than %d > > I think for consistency it'd be good to change 'em all. I'm almost > tempted to put this matter into our message style guide too. +1. -- Michael
signature.asc
Description: PGP signature
