On Thu, Apr 22, 2021 at 8:43 PM Andrew Dunstan <and...@dunslane.net> wrote: > > On 4/22/21 2:52 AM, Michael Paquier wrote: > > On Wed, Apr 21, 2021 at 10:04:40AM -0400, Andrew Dunstan wrote: > >> Here's a patch with these things attended to. > > Thanks. Reading through it, that seems pretty much fine to me. I > > have not spent time checking _version_cmp in details though :) > > > > > pushed with a couple of fixes. >
In my windows environment (Windows 10), I am not able to successfully execute taptests and the failure indicates the line by this commit (4c4eaf3d Make PostgresNode version aware). I am trying to execute tests with command: vcregress.bat taptest src/test/subscription I am seeing below in the log file: Log file: D:/WorkSpace/postgresql/src/test/subscription/tmp_check/log/001_rep_changes_publisher.log List form of pipe open not implemented at D:/WorkSpace/postgresql/src/test/perl/PostgresNode.pm line 1251. # Looks like your test exited with 255 before it could output anything. Can you please let me know if I need to do something additional here? -- With Regards, Amit Kapila.
