At Fri, 14 May 2021 10:04:57 -0400, Tom Lane <t...@sss.pgh.pa.us> wrote in
> Kyotaro Horiguchi <horikyota....@gmail.com> writes:
> > I'm not sure how much we (or people) are strcit on the distinction
> > between the $SUBJECT, isn't '{' a brace generally?
>
> +1. I tend to write "square bracket" or "curly brace" when I want to
> be extra clear, but I think the bare terms are widely understood to
> have those meanings.
Thanks! I think the message is new in 14 so we can fix it right
away. The attached is the version with a commit message added.
If not, I'll register this to the next CF.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From e0794b27583d5cbc50c59497343d77171a169f17 Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <horikyota....@gmail.com>
Date: Thu, 27 May 2021 15:01:44 +0900
Subject: [PATCH] Change confusing 'bracket' use to clearer wording
The current error message looks like this.
LINE 1: select '[1,3]'::int4multirange;
^
DETAIL: Missing left bracket.
It is quite confusing when mentioning a string that contains both of
brackets"[]" and braces"{}".
We are using several kind of wordings point "{}" but the bare word
"brace" is clear enough here.
---
src/backend/utils/adt/multirangetypes.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/backend/utils/adt/multirangetypes.c b/src/backend/utils/adt/multirangetypes.c
index 0b81649779..fbcc27d072 100644
--- a/src/backend/utils/adt/multirangetypes.c
+++ b/src/backend/utils/adt/multirangetypes.c
@@ -146,7 +146,7 @@ multirange_in(PG_FUNCTION_ARGS)
(errcode(ERRCODE_INVALID_TEXT_REPRESENTATION),
errmsg("malformed multirange literal: \"%s\"",
input_str),
- errdetail("Missing left bracket.")));
+ errdetail("Missing left brace.")));
/* consume ranges */
parse_state = MULTIRANGE_BEFORE_RANGE;
@@ -282,7 +282,7 @@ multirange_in(PG_FUNCTION_ARGS)
(errcode(ERRCODE_INVALID_TEXT_REPRESENTATION),
errmsg("malformed multirange literal: \"%s\"",
input_str),
- errdetail("Junk after right bracket.")));
+ errdetail("Junk after right brace.")));
ret = make_multirange(mltrngtypoid, rangetyp, range_count, ranges);
PG_RETURN_MULTIRANGE_P(ret);
--
2.27.0
