On Fri, May 28, 2021 at 05:30:51AM +0000, Paul Guo wrote: > Did some small modification and rebased the code. See attached for the new > version.
Regarding patch 0002, I find the inter-dependencies between write_target_range() and copy_target_range() a bit confusing. There is also a bit of duplication for dry_run, fetch_done and the progress reporting. Perhaps it would be cleaner to have a fallback implementation of copy_file_range() in src/port/ and reduce the footprint of the patch in pg_rewind? Note: FreeBSD 13~ has support for copy_file_range(), nice.. Adding Thomas in CC in case I am missing something. -- Michael
signature.asc
Description: PGP signature
