On 2021-Jun-04, Noah Misch wrote: > On Fri, Apr 09, 2021 at 05:16:11PM -0400, Alvaro Herrera wrote: > > Pushed now. > > This added a PQtraceSetFlags() function. We have a dozen PQset*() functions, > but this and PQresultSetInstanceData() are the only PQSomethingSet() > functions. Is it okay if I rename it to PQsetTraceFlags()? I think that > would be more idiomatic for libpq.
Hmm, there is an obvious parallel between PQtrace() and PQtraceSetFlags() which is lost with your proposed rename. I'm not wedded to the name though, so I'm just -0.1 on the rename. If you feel strongly about it, I won't oppose it. -- Álvaro Herrera Valdivia, Chile "La espina, desde que nace, ya pincha" (Proverbio africano)
