Michael Paquier <mich...@paquier.xyz> writes:
> On Tue, Jun 08, 2021 at 11:21:34AM -0400, Tom Lane wrote:
>> IIUC, what you are proposing to do is replace pgwin32_setenv with
>> src/port/setenv.c. I don't think that's an improvement. setenv.c
>> leaks memory on repeat calls, because it cannot know what
>> pgwin32_setenv knows about how putenv works on that platform.
> Is gaur the only animal that needs this file, by the way?
I think it is. setenv has been in POSIX for awhile, so probably
only very old systems would need that. (This is why I don't care
that much that setenv.c leaks memory. But we can't start using it
on platforms where we *do* care about performance.)
>> (3) Don't try to use the environment variable for this
>> purpose. I'd originally tried to change test5.pgc to just
>> specify gssmode=disable in-line, but that only works
>> nicely for one of the two failing cases. The other one
>> is testing the case of a completely defaulted connection
>> target, so there's no place to add an option without
>> breaking the only unique aspect of that test case.
> FWIW, I'd be rather in favor of doing (3) because this remains simple
> just to take care of an edge case, even if that partially breaks the
> promise to rely on a default connection.
Yeah, it doesn't seem like we need to test that case all that
badly. I'd be okay with dropping that test; or maybe we could
fix things so that the default case succeeds?
regards, tom lane
