On Thu, Jun 10, 2021 at 7:37 PM Anastasia Lubennikova <lubennikov...@gmail.com> wrote: > вт, 8 июн. 2021 г. в 02:44, Anastasia Lubennikova <lubennikov...@gmail.com>: >> Thank you for working on this test set! >> I was especially glad to see the skip-tests option for pg_regress. I think >> it will become a very handy tool for hackers. >> >> To try the patch I had to resolve a few merge conflicts, see a rebased >> version in attachments. >> >> > auth_extra => [ '--create-role', 'repl_role' ]); >> This line and the comment above it look like some copy-paste artifacts. Did >> I get it right? If so, I suggest removing them. >> Other than that, the patch looks good to me. > > For some reason, it failed on cfbot, so I'll switch it back to 'Waiting on > author'. > BTW, do I get it right, that cfbot CI will need some adjustments to print > regression.out for this test? > > See one more revision of the patch attached. It contains the following > changes: > - rebase to recent main > - removed 'auth_extra' piece, that I mentioned above. > - added lacking make clean and gitignore changes.
Thanks! Yeah, there does seem to be a mysterious CI failure there, not reproducible locally for me. You're right that it's not dumping enough information to diagnose the problem... I will look into it tomorrow.
