Peter Geoghegan <p...@bowt.ie> writes:
> ISTM that it would be much more useful to focus on adding an assertion
> (or maybe even a "can't happen" error) that fails when the DEAD/goto
> path is reached with a tuple whose xmin wasn't aborted. If that was in
> place then we would have caught the bug in
> GetOldestNonRemovableTransactionId() far sooner. That might actually
> catch other bugs in the future.
Sounds like a good idea. If we expect that path to be taken only
rarely, then a test-and-elog would be worth its keep. Otherwise
maybe it should just be an Assert.
regards, tom lane
