On Tue, Jun 15, 2021 at 12:01:00PM +0900, Michael Paquier wrote:
> On Tue, Jun 15, 2021 at 11:49:21AM +0900, Masahiko Sawada wrote:
> > On Tue, Jun 15, 2021 at 10:36 AM Bruce Momjian <br...@momjian.us> wrote:
> >> OK, but I need more information on how users will see a difference based
> >> on this commit:
> 
> +1.  That would be good to have in the release notes.
> 
> > I think that since with this commit the server on Windows can handle a
> > file over 4GB, COPY FROM loading data from an over 4GB file and
> > pg_dump dumping a large table work now.
> 
> Segment files or WAL files larger than 4GB also gain from that.
> Anything for which we may finish to do a stat() on benefits from this
> change if running on Windows.  For pg_dump, a workaround in PG <= 13
> was to use --no-sync as the stat() failure came from files with a size
> larger than 4GB.  That's rather sad as that means sacrifying
> durability for more usability :(

OK, I went with this text and put it in the Source Code section since it
applies to several layers of Postgres.

-- 
  Bruce Momjian  <br...@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.

diff --git a/doc/src/sgml/release-14.sgml b/doc/src/sgml/release-14.sgml
index 53221ab8c1..28d0e1396b 100644
--- a/doc/src/sgml/release-14.sgml
+++ b/doc/src/sgml/release-14.sgml
@@ -3553,6 +3553,25 @@ Author: Peter Eisentraut <pe...@eisentraut.org>
 
       <listitem>
 <!--
+Author: Tom Lane <t...@sss.pgh.pa.us>
+2020-10-09 [bed90759f] Fix our Windows stat() emulation to handle file sizes >
+-->
+
+       <para>
+        Allow Windows to properly handle files larger than four gigabytes
+        (Juan José Santamaría Flecha)
+       </para>
+
+       <para>
+        For example this allows <link
+        linkend="sql-copy"><command>COPY,</command></link> <link
+        linkend="configure-options-misc"><acronym>WAL</acronym></link>
+        files, and relation segment files to be larger than four gigabytes.
+       </para>
+      </listitem>
+
+      <listitem>
+<!--
 Author: Peter Eisentraut <pe...@eisentraut.org>
 2021-01-06 [4656e3d66] Replace CLOBBER_CACHE_ALWAYS with run-time GUC
 -->

Reply via email to